Infer OpenCensus resource type based on OpenTelemetry's semantic conventions #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilebox
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
owais,
pjanotti and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1462 +/- ##
==========================================
+ Coverage 90.90% 90.92% +0.01%
==========================================
Files 239 239
Lines 16692 16702 +10
==========================================
+ Hits 15174 15186 +12
+ Misses 1086 1085 -1
+ Partials 432 431 -1
Continue to review full report at Codecov.
|
james-bebbington
approved these changes
Jul 30, 2020
bogdandrutu
approved these changes
Jul 31, 2020
|
@bogdandrutu could we cut a bugfix release with this in order to test it with a production setup ? I have a few customers waiting on it. Thanks ! |
|
@ocervell Note that you may use unreleased OpenTelemetry Collector (or contrib) Docker images with the |
|
@nilebox thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: I have initially tried to fix this issue for Stackdriver exporter only (open-telemetry/opentelemetry-collector-contrib#581), but it seems generic enough to be part of the core.
Description:
Reverse mapping from OpenTelemetry's semantic conventions to OpenCensus resource type.
Since OpenTelemetry has switched to using semantic conventions over explicit resource types, the resource type may now be missing when converted to OpenCensus resource.
In that case we will try to infer the resource type based on documented conventions.
Link to tracking Issue:
The issue has been originally discussed in open-telemetry/opentelemetry-python#951 (comment), pointing to inconsistency between OpenCensus and OpenTelemetry which needs to be addressed.
Testing: Unit tests added for new functionality
Documentation: No documentation needed, we may just refer to the already documented semantic conventions.
/cc @james-bebbington